[Hub Generated] Review request for Microsoft.Consumption to add version stable/2019-01-01 #5718

ampravinr · 2019-04-20T00:30:45Z

If you are a MSFT employee you can view your work branch via this link.

Contribution checklist:

I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and have all been fixed in this PR.

- Added the Usage details download operation. - Added the sample for usage downloads. - Changed the samples to reflect the parameter scope.

AutorestCI · 2019-04-20T00:31:20Z

Automation for azure-sdk-for-python

Encountered an unknown error: (azure-sdk-for-python)

Traceback (most recent call last):
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 33, in exception_to_github
    yield context
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 170, in rest_handle_action
    return rest_pull_close(body, restapi_repo, sdk_pr_target_repo, sdkbase, sdk_tag)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 185, in rest_pull_close
    rest_pr_management(rest_pr, sdk_pr_target_repo, sdk_tag, sdk_default_base)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github_handler.py", line 151, in rest_pr_management
    sdk_tag=sdk_tag
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/SwaggerToSdkNewCLI.py", line 254, in generate_sdk_from_git_object
    with manage_git_folder(gh_token, Path(temp_dir) / Path("rest"), branched_rest_api_id, pr_number=pr_number) as restapi_git_folder, \
  File "/usr/lib/python3.6/contextlib.py", line 81, in __enter__
    return next(self.gen)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 272, in manage_git_folder
    clone_to_path(gh_token, temp_dir, split_git_id[0], branch_or_commit=branch, pr_number=pr_number)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 212, in clone_to_path
    repo.git.checkout(branch_or_commit)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 548, in <lambda>
    return lambda *args, **kwargs: self._call_process(name, *args, **kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 1014, in _call_process
    return self.execute(call, **exec_kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 825, in execute
    raise GitCommandError(command, status, stderr_value, stdout_value)
git.exc.GitCommandError: Cmd('git') failed due to: exit code(128)
  cmdline: git checkout 71d9c4c0f40c95250618f7f624f7deff563aa10f
  stderr: 'fatal: reference is not a tree: 71d9c4c0f40c95250618f7f624f7deff563aa10f'

AutorestCI · 2019-04-20T00:31:39Z

Automation for azure-sdk-for-js

Encountered an unknown error: (azure-sdk-for-js)

Traceback (most recent call last):
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 33, in exception_to_github
    yield context
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 170, in rest_handle_action
    return rest_pull_close(body, restapi_repo, sdk_pr_target_repo, sdkbase, sdk_tag)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 185, in rest_pull_close
    rest_pr_management(rest_pr, sdk_pr_target_repo, sdk_tag, sdk_default_base)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github_handler.py", line 151, in rest_pr_management
    sdk_tag=sdk_tag
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/SwaggerToSdkNewCLI.py", line 254, in generate_sdk_from_git_object
    with manage_git_folder(gh_token, Path(temp_dir) / Path("rest"), branched_rest_api_id, pr_number=pr_number) as restapi_git_folder, \
  File "/usr/lib/python3.6/contextlib.py", line 81, in __enter__
    return next(self.gen)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 272, in manage_git_folder
    clone_to_path(gh_token, temp_dir, split_git_id[0], branch_or_commit=branch, pr_number=pr_number)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 212, in clone_to_path
    repo.git.checkout(branch_or_commit)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 548, in <lambda>
    return lambda *args, **kwargs: self._call_process(name, *args, **kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 1014, in _call_process
    return self.execute(call, **exec_kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 825, in execute
    raise GitCommandError(command, status, stderr_value, stdout_value)
git.exc.GitCommandError: Cmd('git') failed due to: exit code(128)
  cmdline: git checkout 71d9c4c0f40c95250618f7f624f7deff563aa10f
  stderr: 'fatal: reference is not a tree: 71d9c4c0f40c95250618f7f624f7deff563aa10f'

AutorestCI · 2019-04-20T00:32:30Z

Automation for azure-sdk-for-ruby

Encountered an unknown error: (azure-sdk-for-ruby)

Traceback (most recent call last):
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 33, in exception_to_github
    yield context
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 170, in rest_handle_action
    return rest_pull_close(body, restapi_repo, sdk_pr_target_repo, sdkbase, sdk_tag)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 185, in rest_pull_close
    rest_pr_management(rest_pr, sdk_pr_target_repo, sdk_tag, sdk_default_base)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github_handler.py", line 151, in rest_pr_management
    sdk_tag=sdk_tag
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/SwaggerToSdkNewCLI.py", line 254, in generate_sdk_from_git_object
    with manage_git_folder(gh_token, Path(temp_dir) / Path("rest"), branched_rest_api_id, pr_number=pr_number) as restapi_git_folder, \
  File "/usr/lib/python3.6/contextlib.py", line 81, in __enter__
    return next(self.gen)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 272, in manage_git_folder
    clone_to_path(gh_token, temp_dir, split_git_id[0], branch_or_commit=branch, pr_number=pr_number)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 212, in clone_to_path
    repo.git.checkout(branch_or_commit)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 548, in <lambda>
    return lambda *args, **kwargs: self._call_process(name, *args, **kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 1014, in _call_process
    return self.execute(call, **exec_kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 825, in execute
    raise GitCommandError(command, status, stderr_value, stdout_value)
git.exc.GitCommandError: Cmd('git') failed due to: exit code(128)
  cmdline: git checkout 71d9c4c0f40c95250618f7f624f7deff563aa10f
  stderr: 'fatal: reference is not a tree: 71d9c4c0f40c95250618f7f624f7deff563aa10f'

AutorestCI · 2019-04-20T00:33:42Z

Automation for azure-sdk-for-go

Encountered an unknown error: (azure-sdk-for-go)

Traceback (most recent call last):
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 33, in exception_to_github
    yield context
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 170, in rest_handle_action
    return rest_pull_close(body, restapi_repo, sdk_pr_target_repo, sdkbase, sdk_tag)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 185, in rest_pull_close
    rest_pr_management(rest_pr, sdk_pr_target_repo, sdk_tag, sdk_default_base)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github_handler.py", line 151, in rest_pr_management
    sdk_tag=sdk_tag
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/SwaggerToSdkNewCLI.py", line 254, in generate_sdk_from_git_object
    with manage_git_folder(gh_token, Path(temp_dir) / Path("rest"), branched_rest_api_id, pr_number=pr_number) as restapi_git_folder, \
  File "/usr/lib/python3.6/contextlib.py", line 81, in __enter__
    return next(self.gen)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 272, in manage_git_folder
    clone_to_path(gh_token, temp_dir, split_git_id[0], branch_or_commit=branch, pr_number=pr_number)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 212, in clone_to_path
    repo.git.checkout(branch_or_commit)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 548, in <lambda>
    return lambda *args, **kwargs: self._call_process(name, *args, **kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 1014, in _call_process
    return self.execute(call, **exec_kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 825, in execute
    raise GitCommandError(command, status, stderr_value, stdout_value)
git.exc.GitCommandError: Cmd('git') failed due to: exit code(128)
  cmdline: git checkout 71d9c4c0f40c95250618f7f624f7deff563aa10f
  stderr: 'fatal: reference is not a tree: 71d9c4c0f40c95250618f7f624f7deff563aa10f'

azuresdkci · 2019-04-20T00:53:54Z

Can one of the admins verify this patch?

REST Spec PR 'Azure/azure-rest-api-specs#5718' REST Spec PR Author 'ampravinr' REST Spec PR Last commit

AutorestCI · 2019-04-20T02:49:50Z

Automation for azure-sdk-for-java

Encountered an unknown error: (azure-sdk-for-java)

Traceback (most recent call last):
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 33, in exception_to_github
    yield context
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 170, in rest_handle_action
    return rest_pull_close(body, restapi_repo, sdk_pr_target_repo, sdkbase, sdk_tag)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 185, in rest_pull_close
    rest_pr_management(rest_pr, sdk_pr_target_repo, sdk_tag, sdk_default_base)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github_handler.py", line 151, in rest_pr_management
    sdk_tag=sdk_tag
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/SwaggerToSdkNewCLI.py", line 254, in generate_sdk_from_git_object
    with manage_git_folder(gh_token, Path(temp_dir) / Path("rest"), branched_rest_api_id, pr_number=pr_number) as restapi_git_folder, \
  File "/usr/lib/python3.6/contextlib.py", line 81, in __enter__
    return next(self.gen)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 272, in manage_git_folder
    clone_to_path(gh_token, temp_dir, split_git_id[0], branch_or_commit=branch, pr_number=pr_number)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 212, in clone_to_path
    repo.git.checkout(branch_or_commit)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 548, in <lambda>
    return lambda *args, **kwargs: self._call_process(name, *args, **kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 1014, in _call_process
    return self.execute(call, **exec_kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 825, in execute
    raise GitCommandError(command, status, stderr_value, stdout_value)
git.exc.GitCommandError: Cmd('git') failed due to: exit code(128)
  cmdline: git checkout 71d9c4c0f40c95250618f7f624f7deff563aa10f
  stderr: 'fatal: reference is not a tree: 71d9c4c0f40c95250618f7f624f7deff563aa10f'

dsgouda · 2019-04-22T18:56:26Z

startbuild

REST Spec PR 'Azure/azure-rest-api-specs#5718' REST Spec PR Author 'ampravinr' REST Spec PR Last commit

adxsdknet · 2019-04-22T19:02:33Z

Automation for azure-sdk-for-net

A PR has been created for you:
Azure/azure-sdk-for-net#5888
.NET SDK Commits:
adxsdknet/azure-sdk-for-net@262372c
adxsdknet/azure-sdk-for-net@45e46f3

veronicagg

Please review model validation failures at https://dev.azure.com/azure-sdk/public/_build/results?buildId=20146&view=logs&jobId=8d2f9c49-cd83-5a9d-f3fe-2fd651afa742&taskId=43324f1f-6724-5d61-785f-f0ac9fd256a1&lineStart=64&lineEnd=65&colStart=1&colEnd=1

Removed the additional property - Odata-EntityId

Based on the Doc generated preview, we want to change how the operations listed.

veronicagg · 2019-04-30T00:59:02Z

Still see some failures at https://dev.azure.com/azure-sdk/public/_build/results?buildId=22822. You can check your file using the tool at https://portal.azure-devex-tools.com/app/tools/static-validation/static/errors/default if you'd like.

Fixed the samples for ChargesList

veronicagg · 2019-04-30T18:33:42Z

@ampravinr thanks for fixing the examples issues. The PR is still pending ARM team's approval, please follow up with them for sign-off. FYI - @RyanBensonMSFT who was reviewing your other PR.

ampravinr · 2019-05-02T18:06:45Z

@veronicagg - as per our talk with Arm folks. This is not something we can do for a GA version. We are planning seperate changes for GA version. So I am abandoning these changes for now.

ampravinr · 2019-05-02T18:22:30Z

Hi Veronica, Thanks a lot with all the help on this. We had a discussion with Arm folks on this and unfortunately this change is not something we can do on a GA version. So I will be abandoning these changes on this version - stable/2019-01-01. Note: I closed the PR from my side hoping that will abandon all the merge and the PR. Please let me know if that is not the case. Thanks, Praveen Radhakrishnan From: Veronica Giaudrone <notifications@github.com> Sent: Tuesday, April 30, 2019 11:34 AM To: Azure/azure-rest-api-specs <azure-rest-api-specs@noreply.github.com> Cc: Praveen Radhakrishnan <Praveen.Radhakrishnan@microsoft.com>; Mention <mention@noreply.github.com> Subject: Re: [Azure/azure-rest-api-specs] [Hub Generated] Review request for Microsoft.Consumption to add version stable/2019-01-01 (#5718) @ampravinr<https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fampravinr&data=01%7C01%7CPraveen.Radhakrishnan%40microsoft.com%7C318181257ee044aafa1008d6cd9a6ef3%7C72f988bf86f141af91ab2d7cd011db47%7C1&sdata=35BBDd6YMYip9%2BjS4bofrSDyTD6%2FIEHY%2FwShNEkiufs%3D&reserved=0> thanks for fixing the examples issues. The PR is still pending ARM team's approval, please follow up with them for sign-off. FYI - @RyanBensonMSFT<https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FRyanBensonMSFT&data=01%7C01%7CPraveen.Radhakrishnan%40microsoft.com%7C318181257ee044aafa1008d6cd9a6ef3%7C72f988bf86f141af91ab2d7cd011db47%7C1&sdata=ONTKyt0WY7%2BA7wAQJFq2NqJIoCVwtWdRXQYz8g1XJiQ%3D&reserved=0> who was reviewing your other PR. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub<https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FAzure%2Fazure-rest-api-specs%2Fpull%2F5718%23issuecomment-488064864&data=01%7C01%7CPraveen.Radhakrishnan%40microsoft.com%7C318181257ee044aafa1008d6cd9a6ef3%7C72f988bf86f141af91ab2d7cd011db47%7C1&sdata=OAnpXJZPx6ntn9o500DgAXcQDm%2FMgP%2BvNzUmjLMOgns%3D&reserved=0>, or mute the thread<https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAJXK4GRLOOWT22CP4H7DXRLPTCGJ7ANCNFSM4HHISABQ&data=01%7C01%7CPraveen.Radhakrishnan%40microsoft.com%7C318181257ee044aafa1008d6cd9a6ef3%7C72f988bf86f141af91ab2d7cd011db47%7C1&sdata=dDAc2FLqk0YKEVOx5%2BTLDYPaT%2FJFKQHlHacs3uOsdl4%3D&reserved=0>.

Added usage details download operation

b03216e

- Added the Usage details download operation. - Added the sample for usage downloads. - Changed the samples to reflect the parameter scope.

AutorestCI mentioned this pull request Apr 20, 2019

[AutoPR consumption/resource-manager] [Hub Generated] Review request for Microsoft.Consumption to add version stable/2019-01-01 Azure/azure-sdk-for-js#2377

Closed

AutorestCI mentioned this pull request Apr 20, 2019

[AutoPR consumption/resource-manager] [Hub Generated] Review request for Microsoft.Consumption to add version stable/2019-01-01 Azure/azure-sdk-for-ruby#2413

Closed

AutorestCI mentioned this pull request Apr 20, 2019

[AutoPR consumption/resource-manager] [Hub Generated] Review request for Microsoft.Consumption to add version stable/2019-01-01 Azure/azure-sdk-for-go#4599

Closed

ampravinr requested a review from ms-premp April 20, 2019 00:36

azuresdkci assigned veronicagg Apr 20, 2019

azuresdkci requested a review from veronicagg April 20, 2019 00:52

adxsdknet added a commit to adxsdknet/azure-sdk-for-net that referenced this pull request Apr 20, 2019

.NET SDK Resource Provider:'Consumption'

45e46f3

REST Spec PR 'Azure/azure-rest-api-specs#5718' REST Spec PR Author 'ampravinr' REST Spec PR Last commit

AutorestCI mentioned this pull request Apr 20, 2019

[AutoPR consumption/resource-manager] [Hub Generated] Review request for Microsoft.Consumption to add version stable/2019-01-01 Azure/azure-sdk-for-java#3418

Closed

Azure deleted a comment from adxsdknet Apr 22, 2019

adxsdknet added a commit to adxsdknet/azure-sdk-for-net that referenced this pull request Apr 22, 2019

.NET SDK Resource Provider:'Consumption'

262372c

REST Spec PR 'Azure/azure-rest-api-specs#5718' REST Spec PR Author 'ampravinr' REST Spec PR Last commit

veronicagg added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Apr 23, 2019

veronicagg suggested changes Apr 23, 2019

View reviewed changes

Removed the additional property - Odata-EntityId

dc7c9d3

Removed the additional property - Odata-EntityId

Changing the Operation Id for Downloads.

c0709ec

Based on the Doc generated preview, we want to change how the operations listed.

Fixed the samples for ChargesList

7320388

Fixed the samples for ChargesList

AutorestCI mentioned this pull request Apr 30, 2019

[AutoPR consumption/resource-manager] [Hub Generated] Review request for Microsoft.Consumption to add version stable/2019-01-01 Azure/azure-sdk-for-js#2579

Closed

ampravinr closed this May 2, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Hub Generated] Review request for Microsoft.Consumption to add version stable/2019-01-01 #5718

[Hub Generated] Review request for Microsoft.Consumption to add version stable/2019-01-01 #5718

ampravinr commented Apr 20, 2019

AutorestCI commented Apr 20, 2019 •

edited

Loading

AutorestCI commented Apr 20, 2019 •

edited

Loading

AutorestCI commented Apr 20, 2019 •

edited

Loading

AutorestCI commented Apr 20, 2019 •

edited

Loading

azuresdkci commented Apr 20, 2019

AutorestCI commented Apr 20, 2019 •

edited

Loading

dsgouda commented Apr 22, 2019

adxsdknet commented Apr 22, 2019 •

edited

Loading

veronicagg left a comment

veronicagg commented Apr 30, 2019

veronicagg commented Apr 30, 2019

ampravinr commented May 2, 2019

ampravinr commented May 2, 2019 via email

[Hub Generated] Review request for Microsoft.Consumption to add version stable/2019-01-01 #5718

[Hub Generated] Review request for Microsoft.Consumption to add version stable/2019-01-01 #5718

Conversation

ampravinr commented Apr 20, 2019

Contribution checklist:

AutorestCI commented Apr 20, 2019 • edited Loading

Automation for azure-sdk-for-python

AutorestCI commented Apr 20, 2019 • edited Loading

Automation for azure-sdk-for-js

AutorestCI commented Apr 20, 2019 • edited Loading

Automation for azure-sdk-for-ruby

AutorestCI commented Apr 20, 2019 • edited Loading

Automation for azure-sdk-for-go

azuresdkci commented Apr 20, 2019

AutorestCI commented Apr 20, 2019 • edited Loading

Automation for azure-sdk-for-java

dsgouda commented Apr 22, 2019

adxsdknet commented Apr 22, 2019 • edited Loading

Automation for azure-sdk-for-net

veronicagg left a comment

Choose a reason for hiding this comment

veronicagg commented Apr 30, 2019

veronicagg commented Apr 30, 2019

ampravinr commented May 2, 2019

ampravinr commented May 2, 2019 via email

AutorestCI commented Apr 20, 2019 •

edited

Loading

AutorestCI commented Apr 20, 2019 •

edited

Loading

AutorestCI commented Apr 20, 2019 •

edited

Loading

AutorestCI commented Apr 20, 2019 •

edited

Loading

AutorestCI commented Apr 20, 2019 •

edited

Loading

adxsdknet commented Apr 22, 2019 •

edited

Loading